Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support secondary indexes on Cosmos DB #146

Merged
merged 4 commits into from
Jan 22, 2021
Merged

Support secondary indexes on Cosmos DB #146

merged 4 commits into from
Jan 22, 2021

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Jan 22, 2021

@yito88 yito88 self-assigned this Jan 22, 2021
@yito88 yito88 added the enhancement New feature or request label Jan 22, 2021
feeblefakie
feeblefakie approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie
Copy link
Contributor

@brfrn169 PTAL once again since it's a bit more complex than other PRs.

brfrn169
brfrn169 approved these changes Jan 22, 2021
View reviewed changes
Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@feeblefakie feeblefakie merged commit c9f5e03 into master Jan 22, 2021
@feeblefakie feeblefakie deleted the secondary_index_cosmos branch January 22, 2021 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feeblefakie feeblefakie feeblefakie approved these changes

@brfrn169 brfrn169 brfrn169 approved these changes

Assignees

@yito88 yito88

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yito88 @feeblefakie @brfrn169