-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable dynamo backup #159
Enable dynamo backup #159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Left a clarifying question.
@@ -24,6 +24,7 @@ | |||
[nil "--region REGION" "Region where the tool creates tables for DynamoDB"] | |||
[nil "--prefix NAMESPACE_PREFIX" "Namespace prefix. The prefix is added to all the namespaces."] | |||
[nil "--no-scaling" "Disable auto-scaling"] | |||
[nil "--no-backup" "Disable continuous backup"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question. This option can only be specified for DynamoDB at the moment and would be ignored if specified for other databases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feeblefakie Thank you for the question. Right, it will be ignored for other databases.
https://scalar-labs.atlassian.net/browse/DLT-8207
Enabled the continuous backup (for Point Time In Recovery)
Note:
This doesn't enable the backup of the
scalardb.metadata
table.The restored metadata would be useless because the user table name should be changed.
(DynamoDB cannot restore data to the existing table.)
So, we have to remake the metadata table with this tool with the new prefix after restoring other tables.