Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dynamo backup #159

Merged
merged 3 commits into from
Feb 22, 2021
Merged

Enable dynamo backup #159

merged 3 commits into from
Feb 22, 2021

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Feb 19, 2021

https://scalar-labs.atlassian.net/browse/DLT-8207

Enabled the continuous backup (for Point Time In Recovery)

Note:
This doesn't enable the backup of the scalardb.metadata table.
The restored metadata would be useless because the user table name should be changed.
(DynamoDB cannot restore data to the existing table.)
So, we have to remake the metadata table with this tool with the new prefix after restoring other tables.

@yito88 yito88 added the enhancement New feature or request label Feb 19, 2021
@yito88 yito88 self-assigned this Feb 19, 2021
Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Left a clarifying question.

@@ -24,6 +24,7 @@
[nil "--region REGION" "Region where the tool creates tables for DynamoDB"]
[nil "--prefix NAMESPACE_PREFIX" "Namespace prefix. The prefix is added to all the namespaces."]
[nil "--no-scaling" "Disable auto-scaling"]
[nil "--no-backup" "Disable continuous backup"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question. This option can only be specified for DynamoDB at the moment and would be ignored if specified for other databases?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feeblefakie Thank you for the question. Right, it will be ignored for other databases.

@feeblefakie feeblefakie merged commit 1bffc44 into master Feb 22, 2021
@feeblefakie feeblefakie deleted the enable_dynamo_backup branch February 22, 2021 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants