Remove prefix from indexes of DynamoDB #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feeblefakie
reviewed
Feb 23, 2021
| * @return an {@code Optional} with the returned the full table name | ||
| */ | ||
| @Nonnull | ||
| public Optional<String> forFullTableNameWithoutPrefix() { |
There was a problem hiding this comment.
Suggested change
| public Optional<String> forFullTableNameWithoutPrefix() { | |
| public Optional<String> forUnprefixedFullTableName() { |
This sounds a bit better to me.
| } | ||
|
|
||
| /** | ||
| * Returns the full table name without the prefix with the namespace for this operation |
There was a problem hiding this comment.
Suggested change
| * Returns the full table name without the prefix with the namespace for this operation | |
| * Returns the full table name without the unprefixed namespace for this operation |
|
@yito88 So an index name is a table-local name? I mean, there is no conflict with the same index names between the original table and the restored table? |
|
@brfrn169 Good question! An index table is bound to the table. There is no conflict with that of the source table. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://scalar-labs.atlassian.net/browse/DLT-8207
For DyanmoDB recovery, the prefix for index tables is removed.
Scalar DB requires the same name about index tables after restoring the table. However, the name of the restored tables should be different from that of the source table to restore data. This requirement can be satisfied by adding the prefix. Also, the name of an index table couldn't be modified after restoring the table on DyanmoDB.
That's why I don't want to add a prefix to the index.