Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong index name when a namespace prefix is not specified in the schema tool for DynamoDB #173

Merged
merged 3 commits into from
Mar 11, 2021

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Mar 10, 2021

If a namespace prefix is not specified, the original schema tool for DynamoDB removes the first _ from the table name that's in part of the index name.

For example, let's see the table name is ns.table_1_a and the indexed column name is col1. In this case, the index name will wrongly be ns.table1_a.global_index.col1, the correct one is ns.table_1_a.global_index.col1 though.

@brfrn169 brfrn169 added the bug Something isn't working label Mar 10, 2021
@brfrn169 brfrn169 requested review from feeblefakie and yito88 March 10, 2021 09:45
@brfrn169 brfrn169 self-assigned this Mar 10, 2021
feeblefakie
feeblefakie previously approved these changes Mar 11, 2021
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

yito88
yito88 previously approved these changes Mar 11, 2021
Copy link
Member

@yito88 yito88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good.
It is not a blocking comment.

tools/scalar-schema/src/scalar_schema/dynamo/common.clj Outdated Show resolved Hide resolved
@brfrn169 brfrn169 dismissed stale reviews from yito88 and feeblefakie via c423674 March 11, 2021 07:45
@feeblefakie feeblefakie added bugfix and removed bug Something isn't working labels Mar 11, 2021
@feeblefakie feeblefakie merged commit 59b3328 into master Mar 11, 2021
@feeblefakie feeblefakie deleted the wrong-index-name-in-dynamo branch March 11, 2021 11:45
feeblefakie pushed a commit that referenced this pull request Mar 16, 2021
feeblefakie pushed a commit that referenced this pull request Mar 16, 2021
@brfrn169 brfrn169 changed the title Wrong index name when a namespace prefix is not specified in the sche… Wrong index name when a namespace prefix is not specified in the schema tool for DynamoDB Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants