Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the ConsensusCommit integration tests to cover multi-table transactions #176

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Mar 22, 2021

https://scalar-labs.atlassian.net/browse/DLT-8704

Currently, the ConsensusCommit integration tests are performed only for single table transactions. From the test coverage perspective, we should perform the integration tests for multi-table transactions. We will extend the existing integration tests to cover multi-table transactions in this PR.

@brfrn169 brfrn169 requested review from feeblefakie and yito88 March 22, 2021 12:44
@brfrn169 brfrn169 self-assigned this Mar 22, 2021
@brfrn169 brfrn169 changed the title Extend the ConsensusCommit integration tests to support multi-table t… Extend the ConsensusCommit integration tests to cover multi-table transactions Mar 22, 2021
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's a great enhancement!

@feeblefakie feeblefakie merged commit cf15ae0 into master Mar 23, 2021
@feeblefakie feeblefakie deleted the multi-table-integration-tests branch March 23, 2021 02:33
@brfrn169 brfrn169 removed the bugfix label Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants