Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for endpoint_override in Schema Tool for DynamoDB #183

Merged
merged 2 commits into from
Apr 12, 2021

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Apr 9, 2021

https://scalar-labs.atlassian.net/browse/DLT-8880

By supporting endpoint_override in Schema Tool for DynamoDB, we can use DynamoDB local that is a downloadable version of DynamoDB that enables developers to develop and test applications using a version of DynamoDB running in your own development environment:
https://hub.docker.com/r/amazon/dynamodb-local

It will be useful for test.

@brfrn169 brfrn169 requested review from feeblefakie and yito88 April 9, 2021 04:51
@brfrn169 brfrn169 self-assigned this Apr 9, 2021
feeblefakie
feeblefakie previously approved these changes Apr 11, 2021
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

tools/scalar-schema/src/scalar_schema/core.clj Outdated Show resolved Hide resolved
@feeblefakie feeblefakie merged commit 9eb3515 into master Apr 12, 2021
@feeblefakie feeblefakie deleted the support-endpoint-override-dynamo branch April 12, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants