Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the behavior with -D (deleting all tables) in Schema Tool #184

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

brfrn169
Copy link
Collaborator

https://scalar-labs.atlassian.net/browse/DLT-8878

Currently, Schema Tool for JDBC doesn’t drop schemas and the metadata table/schema, which is different behavior from the others. We should unify it in this PR.

@brfrn169 brfrn169 requested review from feeblefakie and yito88 April 13, 2021 08:56
@brfrn169 brfrn169 self-assigned this Apr 13, 2021
feeblefakie
feeblefakie previously approved these changes Apr 14, 2021
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
But, I feel this PR includes some unrelated changes (e.g., naming and format changes).
If it's easy to do, can you separate them into 2 PRs (one for changes for -D and the other for refactoring)?

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 042442d into master Apr 14, 2021
@feeblefakie feeblefakie deleted the unify-behavior-with-D branch April 14, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants