Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for Oracle to CI #190

Merged
merged 3 commits into from
Apr 19, 2021

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Apr 16, 2021

https://scalar-labs.atlassian.net/browse/DLT-8778

I was finally able to run Oracle docker container in CircleCI and run the integration tests for Oracle successfully!

@brfrn169 brfrn169 requested a review from feeblefakie April 16, 2021 04:01
@brfrn169 brfrn169 self-assigned this Apr 16, 2021
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 844f9e0 into master Apr 19, 2021
@feeblefakie feeblefakie deleted the add-integration-test-for-oracle-to-ci branch April 19, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants