Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade guice version to 5.0.1 for java 11 compatibility #194

Merged
merged 3 commits into from
May 10, 2021

Conversation

scalar-boney
Copy link
Contributor

Upgrade the guice version to avoid some warnings with java 11

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/Users/boney/Documents/scalar-labs/15-mar-2021/scalar/client/build/install/client/lib/guice-4.2.0.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

@feeblefakie
Copy link
Contributor

@scalar-boney Please don't skip the CI if it is ready for review.

@scalar-boney
Copy link
Contributor Author

@scalar-boney Please don't skip the CI if it is ready for review.

Sorry, CI test completed successfully.

Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked that upgrading the guice version doesn't add any warnings (like deprecated classes/methods), and the integration tests (running in java 8) worked. LGTM!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@feeblefakie feeblefakie merged commit a1eb941 into master May 10, 2021
@feeblefakie feeblefakie deleted the upgrade-guice-version branch May 10, 2021 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants