Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some more useful methods to Key.Builder #206

Merged
merged 1 commit into from
May 31, 2021
Merged

Add some more useful methods to Key.Builder #206

merged 1 commit into from
May 31, 2021

Conversation

brfrn169
Copy link
Collaborator

I added two methods (add() and addAll()) to the Key.Builder class. Please take a look!

@brfrn169 brfrn169 requested a review from feeblefakie May 29, 2021 12:52
@brfrn169 brfrn169 self-assigned this May 29, 2021
feeblefakie
feeblefakie approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 0a104b3 into master May 31, 2021
@feeblefakie feeblefakie deleted the add-some-more-useful-methods-to-key-builder branch May 31, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feeblefakie feeblefakie feeblefakie approved these changes

Assignees

@brfrn169 brfrn169

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brfrn169 @feeblefakie