Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some refactoring for JdbcTransaction #213

Merged
merged 1 commit into from
Jun 5, 2021
Merged

Some refactoring for JdbcTransaction #213

merged 1 commit into from
Jun 5, 2021

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Jun 4, 2021

What I did here is as follows:

  • Add a pseudo transaction ID txId to JdbcTransaction
  • Make JdbcTransactionManager always return UNKNOWN

Please take a look!

@brfrn169 brfrn169 requested a review from feeblefakie June 4, 2021 23:38
@brfrn169 brfrn169 self-assigned this Jun 4, 2021
feeblefakie
feeblefakie approved these changes Jun 5, 2021
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
But, I'm not sure why this is needed. It's for grpc server?

@feeblefakie feeblefakie merged commit faed3c7 into master Jun 5, 2021
@feeblefakie feeblefakie deleted the some-refactoring-for-jdbc-transaction branch June 5, 2021 00:32
@brfrn169
Copy link
Collaborator Author

brfrn169 commented Jun 5, 2021

Thank you for reviewing and merging this!

Yes, it's for the grpc server. I'm thinking about using the txId in the grpc server. That's why I needed this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feeblefakie feeblefakie feeblefakie approved these changes

Assignees

@brfrn169 brfrn169

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brfrn169 @feeblefakie