Refactor the integration tests for transaction #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brfrn169
force-pushed
the
refactor-integration-tests-for-transaction
branch
from
6770e47 to
29bd058
Compare
brfrn169
force-pushed
the
refactor-integration-tests-for-transaction
branch
from
29bd058 to
0d42999
Compare
feeblefakie
reviewed
Jun 10, 2021
| @@ -841,14 +837,14 @@ public void get_GetGivenForDeletedWhenCoordinatorStateNotExistAndExpired_ShouldA | |||
| public void getAndScan_CommitHappenedInBetween_ShouldReadRepeatably() | |||
| throws CrudException, CommitException, UnknownTransactionStatusException { | |||
| // Arrange | |||
| DistributedTransaction transaction = manager.start(); | |||
| ConsensusCommit transaction = manager.start(); | |||
There was a problem hiding this comment.
Just a question. Is there any reason of using ConsensusCommit instead of DistributedTransaction?
(usually we should use DistributedTransaction, right?)
There was a problem hiding this comment.
Thank you for reviewing this!
The reason for those changes is that the integration tests are actually just for ConsensusCommit, but not for general DistributedTransaction (I found that when I tried to use it for gRPC transactions, but I couldn't). To highlight that, I made those changes, but they are not very important. And yes, usually we should use DistributedTransaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very minor change. Please take a look!