Adding beginner friendly precisions #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MilanCorreggio Thank you for the PR. For Scalar DB PRs, please add @brfrn169 and me and we will add other reviewers additionally as needed. |
brfrn169
reviewed
Jul 5, 2021
feeblefakie
reviewed
Jul 5, 2021
| @@ -147,6 +149,7 @@ $ ../../gradlew run --args="-mode storage -action pay -amount 100 -to merchant1 | |||
| ## Set up database schema with transaction | |||
|
|
|||
| To apply transaction, we can just add a key `transaction` and value as `true` in Scalar DB scheme. | |||
| You can modify the json file `emoney-storage.json` by the json object bellow. | |||
There was a problem hiding this comment.
I think there is emoney-transaction.json so we don't need this line.
Instead, I think we should say so.
Suggested change
| You can modify the json file `emoney-storage.json` by the json object bellow. |
There was a problem hiding this comment.
@feeblefakie san,
Sorry to disturb you.
Can we modify it like You can create a JSON file emoney-transaction.json by the JSON object below.
There was a problem hiding this comment.
At this line we already created the JSON file. We are doing the second test using transacion as true, so i suppose that modify is ok here.
scalar-boney
approved these changes
Jul 5, 2021
scalar-boney
reviewed
Jul 5, 2021
scalar-boney
previously approved these changes
Jul 5, 2021
feeblefakie
reviewed
Jul 6, 2021
| @@ -30,6 +30,7 @@ $ cd docs/getting-started | |||
|
|
|||
| First of all, you need to define how the data will be organized (a.k.a database schema) in the application with Scalar DB database schema. | |||
| Here is a database schema for the sample application. For the supported data types, please see [this doc](schema.md) for more details. | |||
| You can create a JSON file `emoney-transaction.json` by the JSON object below. | |||
There was a problem hiding this comment.
Suggested change
| You can create a JSON file `emoney-transaction.json` by the JSON object below. | |
| You can create a JSON file `emoney-storage.json` with the JSON below. |
Since it's for storage.
| @@ -144,9 +145,10 @@ $ ../../gradlew run --args="-mode storage -action charge -amount 0 -to merchant1 | |||
| $ ../../gradlew run --args="-mode storage -action pay -amount 100 -to merchant1 -from user1" | |||
| ``` | |||
|
|
|||
| ## Set up database schema with transaction | |||
| ## Set up database schema for transaction | |||
|
|
|||
| To apply transaction, we can just add a key `transaction` and value as `true` in Scalar DB scheme. | |||
There was a problem hiding this comment.
Suggested change
| To apply transaction, we can just add a key `transaction` and value as `true` in Scalar DB scheme. | |
| To use transaction, we can just add a key `transaction` and value as `true` in the Scalar DB scheme we used. |
|
|
||
| To apply transaction, we can just add a key `transaction` and value as `true` in Scalar DB scheme. | ||
| You can modify the JSON file `emoney-storage.json` by the json object bellow. |
There was a problem hiding this comment.
Suggested change
| You can modify the JSON file `emoney-storage.json` by the json object bellow. | |
| You can create the JSON a `emoney-transaction.json` with the JSON below. |
We are using emoney-transaction.json below so I think we should mention the name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.