-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GetBuilder and ScanBuilder #2352
Conversation
@@ -1078,7 +1068,7 @@ public BuildableGetFromExistingWithOngoingWhereOr or(AndConditionSet andConditio | |||
} | |||
|
|||
public static class BuildableGetFromExistingWithOngoingWhereOr | |||
extends BuildableGetFromExistingWithOngoingWhere | |||
extends BuildableGetFromExistingWithWhere |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, BuildableGetFromExistingWithOngoingWhere
implements both And<BuildableGetFromExistingWithOngoingWhereAnd>
and Or<BuildableGetFromExistingWithOngoingWhereOr>
...
I hope Java code analysis or something detects duplicated implementation (in this case, both BuildableGetFromExistingWithOngoingWhereOr
and BuildableGetFromExistingWithOngoingWhere
implement Or<BuildableGetFromExistingWithOngoingWhereOr>
) to notice something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
I checked this in my local env and it worked correctly. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Description
This PR fixes bugs in GetBuilder and ScanBuilder, which wrongly enable where() to continue with “and” in the disjunctive normal form context and for “or” vice vasa. They were due to incorrect inheritance.
Related issues and/or PRs
The bugs were introduced in the following PRs.
So, the
ScanBuilder
fix should be included in the minor versions >= 3.10, I think.Changes made
Checklist
Additional notes (optional)
N/A
Release notes
Fixed bugs in GetBuilder and ScanBuilder.