Make Scalar DB transactions be able to abort eagerly #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feeblefakie
reviewed
Jul 6, 2021
| @@ -140,6 +140,11 @@ public TransactionState getState(String txId) { | |||
| return TransactionState.UNKNOWN; // always returns UNKNOWN | |||
| } | |||
|
|
|||
| @Override | |||
| public TransactionState abort(String txId) { | |||
| return TransactionState.UNKNOWN; // always returns UNKNOWN | |||
There was a problem hiding this comment.
I rethought this method and getState method.
I now think it's better to throw an exception since the application cannot rely on the APIs.
(I think, If UNKNOWN is returned, users would expect if it is returning something else sometimes or eventually)
Thought?
There was a problem hiding this comment.
Thank you for reviewing this!
Yes, I agree that the methods should throw an exception (UnsupportedOperationException) in the JDBC transaction. I will fix it in that way. Thanks!
|
@brfrn169 Sorry, please rebuild the rpc to resolve the conflict. |
brfrn169
force-pushed
the
make-transactions-be-able-to-abort-eagerly
branch
from
02337c9 to
d6290e9
Compare
|
@feeblefakie I rebased this to fix the conflicts. Please take a look at it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://scalar-labs.atlassian.net/browse/DLT-9267
Please take a look!