Add transaction manager config #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feeblefakie
previously approved these changes
Jul 9, 2021
| @@ -132,6 +139,35 @@ protected void load() { | |||
| namespacePrefix = Optional.empty(); | |||
| } | |||
|
|
|||
| if (Strings.isNullOrEmpty(props.getProperty(TRANSACTION_MANAGER))) { | |||
| transactionManagerClass = ConsensusCommitManager.class; | |||
| } else { | |||
There was a problem hiding this comment.
Very minor suggestion. I won't argue against it.
transactionManagerClass = ConsensusCommitManager.class;
if (!Strings.isNullOrEmpty(props.getProperty(TRANSACTION_MANAGER))) {
brfrn169
added
backward-incompatible
and removed
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support transactions through the Scalar DB server, I added a new transaction manager property (
scalar.db.transaction_manager). We can setconsensus-commit(default) orjdbcorgrpcto this property. When we setgrpc, we can perform transactions through the Scalar DB server. And if we setjdbc, we also need to setjdbctoscalar.db.storage.I also removed the
scalar.db.jdbc.transaction_manager_typeproperty in this PR because we can replace it with the new property. So this is an incompatible change.Please take a look!