Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics to Scalar DB Server #245

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Add metrics to Scalar DB Server #245

merged 2 commits into from
Jul 15, 2021

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Jul 14, 2021 •
edited
Loading

I used the dropwizard metrics lib to expose the Scalar DB Server metrics:
https://github.com/dropwizard/metrics

And the metrics are exposed via JMX by using JmxReporter in dropwizard metrics.

The following metrics are exposed:

  • totalSucceeded (produced by Counter)
  • totalFailed (produced by Counter)
  • metrics for per gRPC endpoint (produced by Timer)
    • Max
    • Min
    • Mean
    • 50thPercentile
    • 75thPercentile
    • 95thPercentile
    • 98thPercentile
    • 99thPercentile
    • 999thPercentile
    • StdDev
    • DurationUnit
    • Count
    • OneMinuteRate
    • FiveMinuteRate
    • FifteenMinuteRate
    • MeanRate
    • RateUnit

Please take a look!

@brfrn169 brfrn169 added the enhancement New feature or request label Jul 14, 2021
@brfrn169 brfrn169 requested a review from feeblefakie July 14, 2021 14:25
@brfrn169 brfrn169 self-assigned this Jul 14, 2021
@brfrn169 brfrn169 force-pushed the add-metrics-to-server branch from 88ed16e to 5f9a5fa Compare July 15, 2021 00:21
feeblefakie
feeblefakie approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's pretty nice! LGTM. Thank you!

@feeblefakie feeblefakie merged commit de34596 into master Jul 15, 2021
@feeblefakie feeblefakie deleted the add-metrics-to-server branch July 15, 2021 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feeblefakie feeblefakie feeblefakie approved these changes

Assignees

@brfrn169 brfrn169

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brfrn169 @feeblefakie