Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add importTable without overrideColumnsType to DecoratedDistributedTransactionAdmin #2476

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Add importTable without overrideColumnsType to DecoratedDistributedTransactionAdmin #2476

merged 1 commit into from
Jan 22, 2025
+6 −0

Conversation

brfrn169
Copy link
Collaborator

Description

This PR adds the importTable method without the overrideColumnsType argument to DecoratedDistributedTransactionAdmin.

Related issues and/or PRs

N/A

Changes made

Add the importTable method without the overrideColumnsType argument to DecoratedDistributedTransactionAdmin.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@brfrn169 brfrn169 self-assigned this Jan 22, 2025
Torch3333
Torch3333 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

komamitsu
komamitsu approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for compatibility?

The change itself looks good! 👍

@brfrn169
Copy link
Collaborator Author

Is this for compatibility?

@komamitsu Rather than for compatibility, this is for consistency. Since DecoratedDistributedTransactionAdmin implements other methods, including overridden ones, except for importTable, I think we should do the same for importTable. Thanks.

@brfrn169 brfrn169 merged commit 46726d9 into master Jan 22, 2025
48 checks passed
@brfrn169 brfrn169 deleted the add-importTable-without-overrideColumnsType-to-DecoratedDistributedTransactionAdmin branch January 22, 2025 07:30
feeblefakie pushed a commit that referenced this pull request Jan 22, 2025
@brfrn169
Add importTable without overrideColumnsType to DecoratedDistributedTr…
ca40c33 
…ansactionAdmin (#2476)
@feeblefakie feeblefakie mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torch3333 Torch3333 Torch3333 approved these changes

@komamitsu komamitsu komamitsu approved these changes

@feeblefakie feeblefakie Awaiting requested review from feeblefakie

Assignees

@brfrn169 brfrn169

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brfrn169 @komamitsu @Torch3333