Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Prometheus HTTP endpoint when the port is specified to zero in Scalar DB server #260

Merged

Conversation

brfrn169
Copy link
Collaborator

Please take a look!

@brfrn169 brfrn169 self-assigned this Jul 29, 2021
Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit d4df547 into master Aug 2, 2021
@feeblefakie feeblefakie deleted the disable-prometheus-endpoint-when-specified-to-zero branch August 2, 2021 11:51
brfrn169 added a commit that referenced this pull request Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants