Introduce Spotbugs plugin #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brfrn169
force-pushed
the
introduce-spotbugs-plugin
branch
from
96adc61 to
8748afd
Compare
Torch3333
reviewed
Aug 2, 2021
There was a problem hiding this comment.
I think it's a good idea. I agree that it may become troublesome for some of the rules that cause a lot of false positive but I wonder if it will often trigger, personally I think we could try this tool for some time and then see if it's an hindrance or not. Also, I will need to try the Intellij plugin as well.
Besides, thanks for all the fixes 🙂
feeblefakie
reviewed
Aug 2, 2021
| @@ -1,7 +1,5 @@ | |||
| package com.scalar.db.storage.cassandra; | |||
There was a problem hiding this comment.
I'm wondering what was wrong with the class.
There was a problem hiding this comment.
It was the one to fix a synchronized related warning. Let's discuss it later.
brfrn169
added a commit
that referenced
this pull request
Aug 3, 2021
brfrn169
added a commit
that referenced
this pull request
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
Spotbugsplugin that uses static analysis to look for bugs in Java code. Also, I fixed some Spotbugs errors in this PR.Honestly, I'm not sure it's a good idea for us to use this plugin because it shows some false positives, and we need to use
SuppressFBWarningsannotation to remove them, which might be annoying. But of course, I think it brings many benefits to us. So I would like to discuss whether or not we use this plugin here.Besides this plugin, I'm thinking that we can use the
errorproneplugin, as well:https://errorprone.info/
https://github.com/tbroyer/gradle-errorprone-plugin
Please take a look!