Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Prometheus exporter #274

Merged
merged 4 commits into from
Aug 17, 2021
Merged

Refactor Prometheus exporter #274

merged 4 commits into from
Aug 17, 2021

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Aug 16, 2021 •
edited
Loading

The changes are as follows:

  • Rename the config name scalar.db.server.prometheus_http_endpoint_port to scalar.db.server.prometheus_exporter_port
  • Change the behavior to disable the Prometheus exporter when a negative number port is given
  • Change the Prometheus HTTP endpoint path from /metrics to /stats/prometheus

Please take a look!

@brfrn169 brfrn169 self-assigned this Aug 16, 2021
feeblefakie
feeblefakie reviewed Aug 16, 2021
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good. Left one suggestion.

server/src/main/java/com/scalar/db/server/service/ServerModule.java Outdated Show resolved Hide resolved
@brfrn169 brfrn169 requested a review from feeblefakie August 17, 2021 00:37
feeblefakie
feeblefakie approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169
Copy link
Collaborator Author

It looks like the multi-storage integration test is failing for some reason. I will check it.

Torch3333
Torch3333 approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@brfrn169 brfrn169 merged commit 5e8f881 into master Aug 17, 2021
@brfrn169 brfrn169 deleted the refactor-prometheus-exporter branch August 19, 2021 00:50
brfrn169 added a commit that referenced this pull request Aug 25, 2021
@brfrn169
Refactor Prometheus exporter (#274)
c365f41
@miseyu miseyu mentioned this pull request Sep 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torch3333 Torch3333 Torch3333 approved these changes

@feeblefakie feeblefakie feeblefakie approved these changes

Assignees

@brfrn169 brfrn169

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brfrn169 @feeblefakie @Torch3333