Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename metrics names of Scalar DB server #277

Merged
merged 3 commits into from
Aug 18, 2021
Merged

Rename metrics names of Scalar DB server #277

merged 3 commits into from
Aug 18, 2021

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Aug 17, 2021

Renamed the names of the metrics on the basis of the following naming rule.

For JMX:

scalardb.stats.<grpc-service-name>.<some-grpc-endpoint-identifier>…

For Prometheus:

scalardb_stats_<grpc-service-name>_<some-grpc-endpoint-identifier>…

Examples for Prometheus:

// total
scalardb_stats_total_success 3268.0
scalardb_stats_total_failure 67.0

// DistributedStorage
scalardb_stats_distributed_storage_get{quantile="0.5",} 0.0026463000000000003
scalardb_stats_distributed_storage_get{quantile="0.75",} 0.0034989
scalardb_stats_distributed_storage_get{quantile="0.95",} 0.0057957
scalardb_stats_distributed_storage_get{quantile="0.98",} 0.007284400000000001
scalardb_stats_distributed_storage_get{quantile="0.99",} 0.0094631
scalardb_stats_distributed_storage_get{quantile="0.999",} 0.012586600000000002
scalardb_stats_distributed_storage_get_count 317.0
scalardb_stats_distributed_storage_get_success 313.0
scalardb_stats_distributed_storage_get_failure 4.0

scalardb_stats_distributed_storage_scan_open_scanner{quantile="0.5",} 0.0024397
scalardb_stats_distributed_storage_scan_open_scanner{quantile="0.75",} 0.0032456000000000004
scalardb_stats_distributed_storage_scan_open_scanner{quantile="0.95",} 0.006448400000000001
scalardb_stats_distributed_storage_scan_open_scanner{quantile="0.98",} 0.0087758
scalardb_stats_distributed_storage_scan_open_scanner{quantile="0.99",} 0.0126256
scalardb_stats_distributed_storage_scan_open_scanner{quantile="0.999",} 0.0126256
scalardb_stats_distributed_storage_scan_open_scanner_count 77.0
scalardb_stats_distributed_storage_scan_open_scanner_success 76.0
scalardb_stats_distributed_storage_scan_open_scanner_failure 1.0

// DistributedStorageAdmin
scalardb_stats_distributed_storage_admin_get_table_metadata{quantile="0.5",} 0.0015512000000000002
scalardb_stats_distributed_storage_admin_get_table_metadata{quantile="0.75",} 0.0032665000000000003
scalardb_stats_distributed_storage_admin_get_table_metadata{quantile="0.95",} 0.24264650000000001
scalardb_stats_distributed_storage_admin_get_table_metadata{quantile="0.98",} 0.24264650000000001
scalardb_stats_distributed_storage_admin_get_table_metadata{quantile="0.99",} 0.24264650000000001
scalardb_stats_distributed_storage_admin_get_table_metadata{quantile="0.999",} 0.24264650000000001
scalardb_stats_distributed_storage_admin_get_table_metadata_count 12.0
scalardb_stats_distributed_storage_admin_get_table_metadata_success 12.0

// DistributedTransaction
scalardb_stats_distributed_transaction_transaction_start{quantile="0.5",} 1.6690000000000002E-4
scalardb_stats_distributed_transaction_transaction_start{quantile="0.75",} 2.529E-4
scalardb_stats_distributed_transaction_transaction_start{quantile="0.95",} 7.295E-4
scalardb_stats_distributed_transaction_transaction_start{quantile="0.98",} 8.715000000000001E-4
scalardb_stats_distributed_transaction_transaction_start{quantile="0.99",} 0.0012335
scalardb_stats_distributed_transaction_transaction_start{quantile="0.999",} 0.0061697
scalardb_stats_distributed_transaction_transaction_start_count 162.0
scalardb_stats_distributed_transaction_transaction_start_success 161.0
scalardb_stats_distributed_transaction_transaction_start_failure 1.0

scalardb_stats_distributed_transaction_transaction_get{quantile="0.5",} 0.0031442
scalardb_stats_distributed_transaction_transaction_get{quantile="0.75",} 0.0040068000000000005
scalardb_stats_distributed_transaction_transaction_get{quantile="0.95",} 0.0061497
scalardb_stats_distributed_transaction_transaction_get{quantile="0.98",} 0.009380300000000001
scalardb_stats_distributed_transaction_transaction_get{quantile="0.99",} 0.0445351
scalardb_stats_distributed_transaction_transaction_get{quantile="0.999",} 0.0527895
scalardb_stats_distributed_transaction_transaction_get_count 183.0
scalardb_stats_distributed_transaction_transaction_get_success 183.0

Please take a look!

@brfrn169 brfrn169 self-assigned this Aug 17, 2021
Torch3333
Torch3333 previously approved these changes Aug 17, 2021
Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

feeblefakie
feeblefakie previously approved these changes Aug 18, 2021
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie
Copy link
Contributor

@brfrn169 There is a simple conflict that I can resolve with the GitHub editor but it would be better if you can resolve it. 🙇

@brfrn169 brfrn169 dismissed stale reviews from feeblefakie and Torch3333 via 0a7cc7e August 18, 2021 14:12
@brfrn169 brfrn169 merged commit 7deb092 into master Aug 18, 2021
@brfrn169 brfrn169 deleted the rename-metrics branch August 19, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants