Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some attributes to Oracle tables for performance #285

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Add some attributes to Oracle tables for performance #285

merged 1 commit into from
Aug 26, 2021

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Aug 23, 2021 •
edited
Loading

I added the following three attributes to Oracle tables for better performance:

  • ROWDEPENDENCIES
  • INITRANS (to 3)
  • MAXTRANS (to 255)

We have already confirmed that the performance was improved after adding these attributes.

Please take a look!

Torch3333
Torch3333 approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM but I left a question.

core/src/main/java/com/scalar/db/storage/jdbc/JdbcDatabaseAdmin.java Show resolved Hide resolved
@brfrn169 brfrn169 self-assigned this Aug 23, 2021
feeblefakie
feeblefakie approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 21cdff7 into master Aug 26, 2021
@feeblefakie feeblefakie deleted the add-some-attributes-for-to-oracle-tables branch August 26, 2021 05:15
brfrn169 added a commit that referenced this pull request Sep 15, 2021
@brfrn169
Add some attributes to Oracle tables for performance (#285)
5806d49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torch3333 Torch3333 Torch3333 approved these changes

@feeblefakie feeblefakie feeblefakie approved these changes

Assignees

@brfrn169 brfrn169

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brfrn169 @feeblefakie @Torch3333