-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize Cosmos DB Admin implementation #290
Finalize Cosmos DB Admin implementation #290
Conversation
…nt_create_drop_truncate_to_cosmosdb_admin # Conflicts: # core/src/integration-test/java/com/scalar/db/storage/cosmos/CosmosAdminIntegrationTest.java # core/src/integration-test/java/com/scalar/db/storage/cosmos/CosmosIntegrationTest.java # core/src/integration-test/java/com/scalar/db/transaction/consensuscommit/ConsensusCommitIntegrationTestBase.java # core/src/integration-test/java/com/scalar/db/transaction/consensuscommit/ConsensusCommitWithCosmosIntegrationTest.java # core/src/main/java/com/scalar/db/storage/cosmos/CosmosAdmin.java # core/src/test/java/com/scalar/db/storage/cosmos/CosmosTableMetadataManagerTest.java
The failed CI is caused by a failure to install |
The CI is fixed by #292 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
@@ -0,0 +1,110 @@ | |||
function mutate(num, ...args) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍 It should be managed in core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
This PR adds not yet implemented methods in the Cosmos DB Admin class.
Please have a look, thank you.