Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize Cosmos DB Admin implementation #290

Merged
merged 21 commits into from
Aug 30, 2021

Conversation

Torch3333
Copy link
Contributor

@Torch3333 Torch3333 commented Aug 27, 2021

This PR adds not yet implemented methods in the Cosmos DB Admin class.
Please have a look, thank you.

Vincent Guilpain added 6 commits August 20, 2021 15:16
…nt_create_drop_truncate_to_cosmosdb_admin

# Conflicts:
#	core/src/integration-test/java/com/scalar/db/storage/cosmos/CosmosAdminIntegrationTest.java
#	core/src/integration-test/java/com/scalar/db/storage/cosmos/CosmosIntegrationTest.java
#	core/src/integration-test/java/com/scalar/db/transaction/consensuscommit/ConsensusCommitIntegrationTestBase.java
#	core/src/integration-test/java/com/scalar/db/transaction/consensuscommit/ConsensusCommitWithCosmosIntegrationTest.java
#	core/src/main/java/com/scalar/db/storage/cosmos/CosmosAdmin.java
#	core/src/test/java/com/scalar/db/storage/cosmos/CosmosTableMetadataManagerTest.java
@Torch3333 Torch3333 changed the title WIP Finialize Cosmos DB Admin implementation Finialize Cosmos DB Admin implementation Aug 30, 2021
@Torch3333 Torch3333 changed the title Finialize Cosmos DB Admin implementation Finalize Cosmos DB Admin implementation Aug 30, 2021
@Torch3333 Torch3333 marked this pull request as ready for review August 30, 2021 00:12
@Torch3333
Copy link
Contributor Author

The failed CI is caused by a failure to install cqlsh. I am looking into it.

@Torch3333
Copy link
Contributor Author

The failed CI is caused by a failure to install cqlsh. I am looking into it.

The CI is fixed by #292

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@@ -0,0 +1,110 @@
function mutate(num, ...args) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 It should be managed in core.

Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169 brfrn169 merged commit a55692b into master Aug 30, 2021
@brfrn169 brfrn169 deleted the implement_create_drop_truncate_to_cosmosdb_admin branch August 31, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants