Introduce GateKeeper that manages the front gate of the server that processes requests #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rocesses requests
brfrn169
force-pushed
the
introduce-GateKeeper
branch
from
922cfbc to
6edf0f8
Compare
Torch3333
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
GateKeeperinterface that manages the front gate of the Scalar DB server that processes requests. And I added the following two implementations:Scalar DB server uses the
GateKeeperinterface to pause/unpause requests for implementing the Scalar Admin interface.For now, the default is
LockFreeGateKeeper, but I will conduct a performance test to compare the two implementations and determine which one we should make the default.Please take a look!