Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GrpcAdmin with new interface #297

Merged
merged 1 commit into from
Sep 6, 2021
Merged

Update GrpcAdmin with new interface #297

merged 1 commit into from
Sep 6, 2021

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Sep 4, 2021

This updates the GrpcAdmin with the changes of the DistributedStorageAdmin interface.

Please take a look!

@brfrn169 brfrn169 requested a review from feeblefakie September 4, 2021 11:47
@brfrn169 brfrn169 self-assigned this Sep 4, 2021
feeblefakie
feeblefakie approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 1d8f662 into master Sep 6, 2021
@feeblefakie feeblefakie deleted the update-grpc-admin-with-new-interface branch September 6, 2021 02:13
brfrn169 added a commit that referenced this pull request Sep 15, 2021
@brfrn169
Update GrpcAdmin with new interface (#297)
a78d091
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feeblefakie feeblefakie feeblefakie approved these changes

Assignees

@brfrn169 brfrn169

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brfrn169 @feeblefakie