Refactor XXXAdmin #317
Merged
Refactor XXXAdmin #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brfrn169
force-pushed
the
refactor-XXXAdmin
branch
from
277eb90 to
5331fc3
Compare
feeblefakie
previously approved these changes
Sep 29, 2021
| @@ -173,7 +173,9 @@ public void mutate(List<? extends Mutation> mutations) throws ExecutionException | |||
|
|
|||
| Utility.setTargetToIfNot(mutations, namespacePrefix, namespace, tableName); | |||
| operationChecker.check(mutations); | |||
| mutations.forEach(operationChecker::check); | |||
| for (Mutation mutation : mutations) { | |||
There was a problem hiding this comment.
Any particular reason for not using forEach?
There was a problem hiding this comment.
Thank you for taking at this!
After this change, operationChecker::check throws ExecutionException. forEach doesn't handle Exception well, so I changed this way.
brfrn169
added a commit
that referenced
this pull request
Oct 31, 2021
brfrn169
added a commit
that referenced
this pull request
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did in this PR is:
XXXAdminandXXXTableMetadataManagerbecause the difference of the two roles are getting ambiguousTableMetadataManageronly for caching table metadataConnectionExceptionandStorageRuntimeExceptionPlease take a look!