Fix duplicate of equal fields in the query when do range scanning with multiple clustering keys in Cassandra adapter #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brfrn169
reviewed
Oct 7, 2021
core/src/main/java/com/scalar/db/storage/cassandra/SelectStatementHandler.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/scalar/db/storage/cassandra/SelectStatementHandler.java
Show resolved
Hide resolved
…ub.com/scalar-labs/scalardb into fix-cassandra-scan-query-with-mul-ckey
… fix-cassandra-scan-query-with-mul-ckey
feeblefakie
previously approved these changes
Oct 7, 2021
| @@ -157,13 +161,15 @@ private void setStart(Select.Where statement, Scan scan) { | |||
| statement.and(gt(start.get(i).getName(), bindMarker())); | |||
| } | |||
| } else { | |||
| statement.and(eq(start.get(i).getName(), bindMarker())); | |||
| String cKeyName = start.get(i).getName(); | |||
There was a problem hiding this comment.
Suggested change
| String cKeyName = start.get(i).getName(); | |
| String clusteringKeyName = start.get(i).getName(); |
Yeah, it's a bit long... but I think it's more clear. (otherwise we need to think what c stands for).
Please update the other parts.
There was a problem hiding this comment.
Thanks. Applied in commit
brfrn169
approved these changes
Oct 7, 2021
brfrn169
pushed a commit
that referenced
this pull request
Oct 31, 2021
…h multiple clustering keys in Cassandra adapter (#328)
brfrn169
pushed a commit
that referenced
this pull request
Oct 31, 2021
…h multiple clustering keys in Cassandra adapter (#328)
brfrn169
pushed a commit
that referenced
this pull request
Nov 1, 2021
…h multiple clustering keys in Cassandra adapter (#328)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When do integration testing with multiple clustering keys, I found that with the current implementation, it conducts duplicate of the equal fields in the query when doing range scanning with provided start and end clustering keys so got failed from Cassandra. For example, the wrong query is
SELECT * FROM integration_testing_FLOAT.test_table_mul_key_FLOAT_BIGINT WHERE c1=? AND c2=? AND c3>=? AND c2=? AND c3<=? ORDER BY c2 ASC,c3 ASC;should be corrected to
SELECT * FROM integration_testing_FLOAT.test_table_mul_key_FLOAT_BIGINT WHERE c1=? AND c2=? AND c3>=? AND c3<=? ORDER BY c2 ASC,c3 ASC;(remove one
AND c2=?)This PR was made for fixing it.
Please take a look. Thank you.