Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow using BLOB type for clustering keys in Cosmos DB adapter #339

Merged

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Oct 7, 2021

A BLOB value is automatically converted to Base64 representations in Cosmos DB SDK, which doesn't preserve the sort order of the original value. So we can't use BLOB type for clustering keys in Cosmos DB adapter. This PR disallows using BLOB type for clustering keys in Cosmos DB adapter. Please take a look!

@brfrn169 brfrn169 self-assigned this Oct 7, 2021
@brfrn169 brfrn169 force-pushed the disallow-using-blog-for-clustering-key-in-cosmos branch from fb7f131 to bc976f9 Compare October 8, 2021 02:22
Copy link
Contributor

@thongdk8 thongdk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 228a894 into master Oct 11, 2021
@feeblefakie feeblefakie deleted the disallow-using-blog-for-clustering-key-in-cosmos branch October 11, 2021 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants