Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict BigIntValue range #340

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Oct 7, 2021

This PRs restricts BigIntValue range from -2^53 to 2^53. The range is determined by the numbers Double-precision floating-point format can exactly represent. After this change, we can treat BigIntValue as Json's Number type without precision error. Please take a look!

@brfrn169 brfrn169 self-assigned this Oct 7, 2021
@brfrn169 brfrn169 force-pushed the ristrict-bigint-value-range branch from 1805f44 to 025a2f3 Compare October 7, 2021 16:14
Copy link
Contributor

@thongdk8 thongdk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit b854a4d into master Oct 11, 2021
@feeblefakie feeblefakie deleted the ristrict-bigint-value-range branch October 11, 2021 01:42
brfrn169 added a commit that referenced this pull request Oct 31, 2021
brfrn169 added a commit that referenced this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants