Add dockerize to Dockerfile for grpc-server #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miseyu
commented
Nov 17, 2021
|
|
||
| ENV SCALARDB_SERVER_OPTS -Dlog4j.configurationFile=file:log4j2.properties | ||
|
|
||
| ENTRYPOINT ["./bin/scalardb-server"] | ||
| CMD ["--config", "database.properties"] | ||
| CMD ["./bin/scalardb-server", "--config", "database.properties"] |
There was a problem hiding this comment.
To support backward compatibility
|
@miseyu Thank you! Is this needed for the scalability test? |
|
@feeblefakie |
feeblefakie
previously approved these changes
Nov 19, 2021
server/Dockerfile
Outdated
| WORKDIR /scalardb/server | ||
|
|
||
| COPY log4j2.properties . | ||
| # Support for use cases where environment variables are used to configure the database |
There was a problem hiding this comment.
Suggested change
| # Support for use cases where environment variables are used to configure the database | |
| # Support use cases where environment variables are used to configure the database |
There was a problem hiding this comment.
I have corrected the problem.
b66edbc
server/README.md
Outdated
| @@ -41,6 +41,9 @@ $ docker run -v <your local configuration file path>:/scalardb/server/database.p | |||
| # For custom log configuration | |||
| $ docker run -v <your local configuration file path>:/scalardb/server/database.properties -v <your custom log4j2 configuration file path>:/scalardb/server/log4j2.properties -d -p 60051:60051 -p 8080:8080 ghcr.io/scalar-labs/scalardb-server:<version> | |||
|
|
|||
| # For set in environment variables | |||
There was a problem hiding this comment.
Suggested change
| # For set in environment variables | |
| # Use environment variables |
There was a problem hiding this comment.
I have corrected the problem.
b66edbc
miseyu
force-pushed
the
support-dockerize
branch
from
31b6833 to
b66edbc
Compare
|
@feeblefakie |
brfrn169
pushed a commit
that referenced
this pull request
Dec 2, 2021
brfrn169
pushed a commit
that referenced
this pull request
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Why?
Usage