Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore JdbcUtils.initDataSource(JdbcConfig config) #417

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Dec 7, 2021

This PR restores the method initDataSource(JdbcConfig config) in JdbcUtils that was removed in #412 to keep the backward compatibility. Please take a look!

@brfrn169 brfrn169 added the bugfix label Dec 7, 2021
@brfrn169 brfrn169 self-assigned this Dec 7, 2021
@brfrn169 brfrn169 force-pushed the restore-init-data-source branch from 0e5ef5b to 6f3793d Compare December 7, 2021 14:33
Copy link
Contributor

@thongdk8 thongdk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit d927f8d into master Dec 8, 2021
@feeblefakie feeblefakie deleted the restore-init-data-source branch December 8, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants