Refactor ImmutableLinkedHashSet #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feeblefakie
approved these changes
Feb 22, 2022
| immutable = true; | ||
| public ImmutableLinkedHashSet(Collection<? extends E> data) { | ||
| super(0); | ||
| this.data = ImmutableSet.copyOf(data); |
There was a problem hiding this comment.
Just wondering. Is it guaranteed to keep the insertion order even if it's copied (not actually copied behind the scene, though) to ImmutableSet?
There was a problem hiding this comment.
Yes, ImmutableSet guarantees to keep the insertion order. Actually, I didn't know that before working on this change, but it does according to the following document:
https://guava.dev/releases/30.1-jre/api/docs/com/google/common/collect/ImmutableCollection.html
Deterministic iteration. The iteration order is always well-defined, depending on how the collection was created. Typically this is insertion order unless an explicit ordering is otherwise specified (e.g. ImmutableSortedSet.naturalOrder()).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
ImmutableLinkedHashSetto useImmutableSetinternally and delegate to it. Please take a look!