Should return primary key when key is contained in WriteSet and ReadSet but the result in ReadSet is empty in Consensus Commit #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et but the result in ReadSet is empty in Consensus Commit
brfrn169
commented
Mar 27, 2022
Comment on lines
+482
to
+483
| put.getPartitionKey().get().forEach(v -> tmp.put(v.getName(), v)); | ||
| put.getClusteringKey().ifPresent(c -> c.get().forEach(v -> tmp.put(v.getName(), v))); |
There was a problem hiding this comment.
This logic includes the primary key into values when the result in the read set is empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a key is contained in WriteSet and ReadSet but the result in ReadSet is empty, it doesn't return primary key, which is not expected behavior. This PR fixes this issue.
Note that this bug is only in the branch
3.5, but themasterbranch doesn't have it. So this bug fix is only for the branch3.5.Please take a look!