Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non useful operation in ScannerImpl from the Cosmos DB adapter #624

Merged

Conversation

Torch3333
Copy link
Contributor

@Torch3333 Torch3333 commented Jul 4, 2022

This updates the ScannerImpl of the Cosmos DB adapter according to this PR comments that could not be applied before the merge on master.
#619 (comment)
#619 (comment)

@Torch3333 Torch3333 changed the title Revise according to comments Remove non useful operations from Cosmos DB adapter ScannerImpl Jul 4, 2022
@Torch3333 Torch3333 changed the title Remove non useful operations from Cosmos DB adapter ScannerImpl Remove non useful operations in ScannerImpl from the Cosmos DB adapter Jul 4, 2022
@Torch3333 Torch3333 self-assigned this Jul 4, 2022
@Torch3333 Torch3333 requested review from brfrn169 and feeblefakie July 4, 2022 05:54
@Torch3333 Torch3333 marked this pull request as ready for review July 4, 2022 05:54
@Torch3333 Torch3333 changed the title Remove non useful operations in ScannerImpl from the Cosmos DB adapter Remove non useful operation in ScannerImpl from the Cosmos DB adapter Jul 4, 2022
Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit a928f6d into master Jul 4, 2022
@feeblefakie feeblefakie deleted the implement_scanner_for_cosmosdb_scan_additional_revisions branch July 4, 2022 13:00
brfrn169 pushed a commit that referenced this pull request Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants