-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for Storage abstraction #625
Conversation
@@ -0,0 +1,714 @@ | |||
# Storage abstraction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added documentation for the Storage abstraction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good overall, thank you!
I left some comments. Please have a look when you can.
Co-authored-by: Vincent Guilpain <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for writing tons of documents! It's great!
Left some suggestions on the Storage abstraction
doc.
Co-authored-by: Hiroyuki Yamada <[email protected]>
Co-authored-by: Hiroyuki Yamada <[email protected]>
@feeblefakie Thank you for taking at this PR! I fixed it based on your feedback in the latest commit. Please take a look again when you have time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Please take a look!