Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for Storage abstraction #625

Merged
merged 6 commits into from
Jul 7, 2022

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Jul 4, 2022

Please take a look!

@brfrn169 brfrn169 self-assigned this Jul 4, 2022
@@ -0,0 +1,714 @@
# Storage abstraction
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added documentation for the Storage abstraction.

@brfrn169 brfrn169 requested review from feeblefakie and Torch3333 July 4, 2022 07:05
Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good overall, thank you!
I left some comments. Please have a look when you can.

docs/storage-abstraction.md Outdated Show resolved Hide resolved
docs/storage-abstraction.md Outdated Show resolved Hide resolved
docs/storage-abstraction.md Outdated Show resolved Hide resolved
docs/storage-abstraction.md Outdated Show resolved Hide resolved
docs/storage-abstraction.md Outdated Show resolved Hide resolved
docs/storage-abstraction.md Outdated Show resolved Hide resolved
docs/storage-abstraction.md Outdated Show resolved Hide resolved
docs/storage-abstraction.md Outdated Show resolved Hide resolved
docs/storage-abstraction.md Outdated Show resolved Hide resolved
docs/storage-abstraction.md Outdated Show resolved Hide resolved
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for writing tons of documents! It's great!
Left some suggestions on the Storage abstraction doc.

docs/api-guide.md Outdated Show resolved Hide resolved
docs/storage-abstraction.md Outdated Show resolved Hide resolved
docs/storage-abstraction.md Outdated Show resolved Hide resolved
docs/storage-abstraction.md Outdated Show resolved Hide resolved
docs/storage-abstraction.md Outdated Show resolved Hide resolved
docs/storage-abstraction.md Outdated Show resolved Hide resolved
docs/storage-abstraction.md Outdated Show resolved Hide resolved
docs/storage-abstraction.md Outdated Show resolved Hide resolved
docs/storage-abstraction.md Outdated Show resolved Hide resolved
docs/storage-abstraction.md Outdated Show resolved Hide resolved
@brfrn169 brfrn169 requested a review from feeblefakie July 7, 2022 00:17
@brfrn169
Copy link
Collaborator Author

brfrn169 commented Jul 7, 2022

@feeblefakie Thank you for taking at this PR! I fixed it based on your feedback in the latest commit. Please take a look again when you have time!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169 brfrn169 merged commit f9e35d2 into master Jul 7, 2022
@brfrn169 brfrn169 deleted the add-doc-for-strage-abstraction branch July 7, 2022 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants