Fix dependency errors for Maven projects #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brfrn169
force-pushed
the
specify-pom-for-pom-type-dependencies
branch
from
f1533b3 to
2cd1112
Compare
brfrn169
changed the title
brfrn169
changed the title
brfrn169
force-pushed
the
specify-pom-for-pom-type-dependencies
branch
from
2cd1112 to
0790c52
Compare
brfrn169
commented
Nov 5, 2022
| @@ -91,11 +91,11 @@ dependencies { | |||
| implementation "org.jooq:jooq:${jooqVersion}" | |||
| implementation "software.amazon.awssdk:applicationautoscaling:${awssdkVersion}" | |||
| implementation "software.amazon.awssdk:dynamodb:${awssdkVersion}" | |||
| implementation "software.amazon.awssdk:core:${awssdkVersion}" | |||
| implementation "software.amazon.awssdk:core:${awssdkVersion}@pom" | |||
There was a problem hiding this comment.
Specified pom type explicitly for the awssdk dependency. This will fix the dependency error.
| implementation "org.apache.commons:commons-dbcp2:${commonsDbcp2Version}" | ||
| implementation "mysql:mysql-connector-java:${mysqlDriverVersion}" | ||
| implementation "org.postgresql:postgresql:${postgresqlDriverVersion}" | ||
| implementation "com.oracle.database.jdbc:ojdbc8-production:${oracleDriverVersion}" | ||
| implementation "com.oracle.database.jdbc:ojdbc8:${oracleDriverVersion}" |
There was a problem hiding this comment.
I tried to specify the pom type explicitly for the Oracle JDBC Driver dependency, and it fixed the dependency error, but the integration test failed with the No suitable driver error for some reason. So I decided to change the dependency to com.oracle.database.jdbc:ojdbc8 because we just need the Oracle JDBC Driver.
I referred to the following document:
https://www.oracle.com/database/technologies/maven-central-guide.html
brfrn169
added a commit
that referenced
this pull request
Nov 16, 2022
brfrn169
added a commit
that referenced
this pull request
Nov 16, 2022
brfrn169
added a commit
that referenced
this pull request
Nov 16, 2022
brfrn169
added a commit
that referenced
this pull request
Nov 16, 2022
brfrn169
added a commit
that referenced
this pull request
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when we build a Maven project with the scalardb dependencies, we face the following dependency error:
This PR fixes this issue. I'll add inline comments for the details. Please take a look!