Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stroke colour picker also change fill colour #285

Closed
xplicit-dev opened this issue Dec 12, 2022 · 4 comments
Closed

Stroke colour picker also change fill colour #285

xplicit-dev opened this issue Dec 12, 2022 · 4 comments
Labels
Released The issue is fixed/considered and released

Comments

@xplicit-dev
Copy link

There is a bug found on Draw Section while using the demo, the stroke color picker also changes the color of the fill color,

step to produce :
1- choose different colors for the stroke and fill
2 - draw any shape,
3- click outside of the canvas / change the draw tool
it changes the color of the fill
@terrychua93
Copy link

image-editor

this from component/common/colorInput/index.jsx

Just hide that code should work

@AhmeeedMostafa AhmeeedMostafa added the TBC (To Be Checked) means the issue needs to get investigated by the product dev./QA label Jan 19, 2023
@AhmeeedMostafa
Copy link
Collaborator

Thanks for noticing we would check this in the future and consider it if it's a real bug.

@AhmeeedMostafa AhmeeedMostafa added Waiting release The issue's code is added in the dev. branch but not yet released and removed TBC (To Be Checked) means the issue needs to get investigated by the product dev./QA labels Feb 9, 2023
AhmeeedMostafa added a commit that referenced this issue Feb 9, 2023
@AhmeeedMostafa
Improve: The behavior of color picker, by splitting the saved fill/st…
d8f1636 
…roke/shadow colors (Issue #285)
@AhmeeedMostafa AhmeeedMostafa added Released The issue is fixed/considered and released and removed Waiting release The issue's code is added in the dev. branch but not yet released labels Feb 10, 2023
@AhmeeedMostafa
Copy link
Collaborator

The issue is improved in version 4.3.8, please re-check it and let us know if all is good.

@xplicit-dev
Copy link
Author

Thanks for the update. the issue has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Released The issue is fixed/considered and released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AhmeeedMostafa @xplicit-dev @terrychua93