-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix filters image ratio display #254
Conversation
…e_options Feat: Add configuration options for rotation
Signed-off-by: John Molakvoæ <[email protected]>
Ping @amrelbialy :) EDIT, maybe @amrw-js ? |
Hey @skjnldsv, We don't consider this as a bug as it was implemented this way. The filters don't need to be aligned with image ratio as we are showing small fixed preview and when you click on any filter you can see the correct ration of the image with correct filter. |
@amrelbialy squashing the images preview is not a bug to you?
We could say that to literally all bugs existing in the world 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with @skjnldsv, cropping the image for a preview is okay, but warping it may give a wrong impression of what the filter would do :) a cropped square preview would be useful when there are multiple aspect ratios in a row, but since all the previews are of the same image, we don't have to crop it either. So nice work @skjnldsv :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is approved but after reviewing the PR's UI & Behavior it's better to replace with center cropping behavior for aligning UI dimensions in all cases considering small & large screens.
Cropping behavior will be considered in the new release
Fix #253
Fix nextcloud/viewer#1335