Fix delete object MD with version ID

Issue: CLDSRV-570
scality · Nov 15, 2024 · de934fa · de934fa
1 parent f7c4f97
commit de934fa
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/lib/api/apiUtils/object/abortMultipartUpload.js b/lib/api/apiUtils/object/abortMultipartUpload.js
@@ -125,8 +125,10 @@ function abortMultipartUpload(authInfo, bucketName, objectKey, uploadId, log,
                 method: 'abortMultipartUpload',
                 bucketName,
                 objectKey,
+                uploadId,
+                versionId: objectMD.versionId
             });
-            return metadata.deleteObjectMD(bucketName, objectKey, undefined, log, err => {
+            return metadata.deleteObjectMD(bucketName, objectKey, {versionId: objectMD.versionId}, log, err => {
                 if (err) {
                     log.error('error deleting object metadata', { error: err });
                 }
@@ -138,9 +140,9 @@ function abortMultipartUpload(authInfo, bucketName, objectKey, uploadId, log,
                 return next(null, mpuBucket, storedParts, destBucket);
             }
             // Filtering parts that has already been delete by the previous step
-            let partLocations = storedParts.map(item => item.value.partLocations);
-            partLocations = [].concat(...partLocations);
-            partLocations = new Set(partLocations.map(loc => loc.key));
+            const partLocations = new Set(
+                storedParts.flatMap(item => item.value.partLocations.map(loc => loc.key))
+            );
             const objectLocationLeft = objectMD.location.filter(loc => !partLocations.has(loc.key));
 
             return async.eachLimit(objectLocationLeft, 5, (loc, cb) => {

diff --git a/tests/unit/api/multipartUpload.js b/tests/unit/api/multipartUpload.js
@@ -2048,8 +2048,7 @@ describe('Multipart Upload API', () => {
                 completeMultipartUpload(authInfo,
                     completeRequest, log, err => {
                         assert(err.is.InternalError);
-                        const MD = metadata.keyMaps.get(bucketName)
-                                                    .get(objectKey);
+                        const MD = metadata.keyMaps.get(bucketName).get(objectKey);
                         assert(MD);
                         assert.strictEqual(MD['x-amz-meta-stuff'],
                             'I am some user metadata');