Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDSRV-246 PutObjectVersion always returns 403 #4697

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

nicolas2bert
Copy link
Contributor

@nicolas2bert nicolas2bert commented Jul 27, 2022

Behavior before merge:
s3:PutObjectVersion and s3:PutObject permissions were required to restore objects (put object version).

Behavior after merge:
Only s3:PutObjectVersion permission is required to restore objects (put object version).

Planning on adding e2e tests in Zenko about assumeRole with s3:PutObjectVersion permission policy cf https://scality.atlassian.net/browse/ZENKO-4303

@bert-e
Copy link
Contributor

bert-e commented Jul 27, 2022

Hello nicolas2bert,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jul 27, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@nicolas2bert
Copy link
Contributor Author

@bert-e approve

@bert-e
Copy link
Contributor

bert-e commented Jul 28, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.5

The following branches will NOT be impacted:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jul 28, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.5

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.4

Please check the status of the associated issue CLDSRV-246.

Goodbye nicolas2bert.

@bert-e bert-e merged commit 9e85e8d into development/8.5 Jul 28, 2022
@bert-e bert-e deleted the bugfix/CLDSRV-246/objectPutVersion branch July 28, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants