Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDSRV-256 fix and test tag conditions updateRequestContexts() helper #4736

Merged

Conversation

jonathan-gramain
Copy link
Contributor

Various issues were in this function that needed a full refactor.

Merged functional tests that were essentially unit tests into the
existing unit tests.

Various issues were in this function that needed a full refactor.

Merged functional tests that were essentially unit tests into the
existing unit tests.
@bert-e
Copy link
Contributor

bert-e commented Aug 12, 2022

Hello jonathan-gramain,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Aug 12, 2022

Incorrect fix version

The Fix Version/s in issue CLDSRV-256 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.10.9

  • 7.70.4

  • 8.4.14

  • 8.5.13

Please check the Fix Version/s of CLDSRV-256, or the target
branch of this pull request.

@jonathan-gramain
Copy link
Contributor Author

ping

@bert-e
Copy link
Contributor

bert-e commented Aug 12, 2022

Conflict

A conflict has been raised during the creation of
integration branch w/8.4/bugfix/CLDSRV-256-fixAndTestUpdateRequestContexts with contents from w/7.70/bugfix/CLDSRV-256-fixAndTestUpdateRequestContexts
and development/8.4.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.4/bugfix/CLDSRV-256-fixAndTestUpdateRequestContexts origin/development/8.4
 $ git merge origin/w/7.70/bugfix/CLDSRV-256-fixAndTestUpdateRequestContexts
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.4/bugfix/CLDSRV-256-fixAndTestUpdateRequestContexts

@bert-e
Copy link
Contributor

bert-e commented Aug 12, 2022

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4

Follow integration pull requests if you would like to be notified of
build statuses by email.

@bert-e
Copy link
Contributor

bert-e commented Aug 12, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@jonathan-gramain
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Aug 17, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/7.10

  • ✔️ development/7.70

  • ✔️ development/8.4

  • ✔️ development/8.5

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Aug 17, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/7.10

  • ✔️ development/7.70

  • ✔️ development/8.4

  • ✔️ development/8.5

The following branches have NOT changed:

  • development/6.4
  • development/7.4

Please check the status of the associated issue CLDSRV-256.

Goodbye jonathan-gramain.

@bert-e bert-e merged commit 5265c1b into development/7.10 Aug 17, 2022
@bert-e bert-e deleted the bugfix/CLDSRV-256-fixAndTestUpdateRequestContexts branch August 17, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants