-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: CLDSRV-278 add github action to release image for fed #4795
feature: CLDSRV-278 add github action to release image for fed #4795
Conversation
Hello miniscruff,My role is to assist you with the merge of this Status report is not available. |
2d32f18
to
d4683c1
Compare
- name: Checkout | ||
uses: actions/checkout@v2 | ||
|
||
- name: Set up Docker Buildx | ||
uses: docker/setup-buildx-action@v1 | ||
|
||
- name: Login to Registry | ||
uses: docker/login-action@v1 | ||
with: | ||
registry: ${{ env.REGISTRY_NAME }} | ||
username: ${{ secrets.REGISTRY_LOGIN }} | ||
password: ${{ secrets.REGISTRY_PASSWORD }} | ||
|
||
- name: Build and push | ||
uses: docker/build-push-action@v2 | ||
with: | ||
context: . | ||
file: images/svc-base/Dockerfile | ||
push: true | ||
tags: "${{ env.REGISTRY_NAME }}/${{env.PROJECT_NAME }}/${{ env.PROJECT_NAME }}:${{ github.event.inputs.tag }}-svc-base" | ||
cache-from: type=gha | ||
cache-to: type=gha,mode=max |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could save most of this by using shared worfklow :
https://github.com/scality/workflows/blob/main/.github/workflows/docker-build.yaml
Then it would look something like :
steps:
uses: scality/workflows/.github/workflows/docker-build.yaml@v1
secrets: inherit
with:
push: true
namespace: ${{ env.PROJECT_NAME }}
name: ${{ env.PROJECT_NAME }}
tag: "${{ github.event.inputs.tag }}-svc-base"
context: images/svc-base/Dockerfile
registry: ${{ env.REGISTRY_NAME }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was not possible to use as the file
input was not being used in that workflow, it is now so switching over.
d4683c1
to
04d13ca
Compare
04d13ca
to
89843bc
Compare
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/8.4/feature/CLDSRV-278/provide-image-for-federation origin/development/8.4
$ git merge origin/w/7.70/feature/CLDSRV-278/provide-image-for-federation
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/8.4/feature/CLDSRV-278/provide-image-for-federation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if you think we should add a workflow that just build this image before merging, to ensure we're not breaking it. (I'll let you be the judge of that).
LGTM
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option
|
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-278. Goodbye miniscruff. |
No description provided.