-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: CLDSRV-282 handle object lock when creating a bucket #4808
bugfix: CLDSRV-282 handle object lock when creating a bucket #4808
Conversation
Hello miniscruff,My role is to assist you with the merge of this Status report is not available. |
* auth results can be an array of arrays * Object.assign needs an empty object or it modifies the original * should be `_isObjectLockEnabled` not `!_isObjectLockEnabled` * add unit tests
e161c6f
to
bbb3e2f
Compare
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option
|
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
If you need to release the project, feel free to bump the project version, as I am not planning to merge my PR this week 😄 |
I will add the bump in the morning, good call |
ConflictA conflict has been raised during the update of Please resolve the conflict on the integration branch ( Here are the steps to resolve this conflict: $ git fetch
$ git checkout w/7.70/bugfix/CLDSRV-282/put-bucket-object-lock-regression
$ git pull # or "git reset --hard origin/w/7.70/bugfix/CLDSRV-282/put-bucket-object-lock-regression"
$ git merge origin/development/7.70
$ # <intense conflict resolution>
$ git commit
$ git merge origin/bugfix/CLDSRV-282/put-bucket-object-lock-regression
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/7.70/bugfix/CLDSRV-282/put-bucket-object-lock-regression |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-282. Goodbye miniscruff. |
_isObjectLockEnabled
not!_isObjectLockEnabled