Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDSRV-576 Cherry-pick for AWS KMS Backend #5698

Merged
merged 9 commits into from
Nov 13, 2024
Merged

CLDSRV-576 Cherry-pick for AWS KMS Backend #5698

merged 9 commits into from
Nov 13, 2024

Conversation

nicolas2bert
Copy link
Contributor

No description provided.

outscale-fba and others added 5 commits November 12, 2024 14:59
@outscale-fba @nicolas2bert
FT: Provide AWS KMS connector for bucket ciphering
994f58f 
Add configuration mechanism for the new AWS KMS connector.
Depends on changes in Arsenal to have support of this new connector.

(cherry picked from commit 9bf534d)
@outscale-fba @nicolas2bert
FT: ciphering, use generateDataKey operation of the KMS backend when
d6f059b 
available

Up to now, the datakey was always generated using a locally generated
random number.
This commit allow to use the "generateDataKey" operation of a KMS when
it is implemented. It fallback to random number generation if not
available.
The benefit of generating the datakey in the KMS is a better entropy
source resulting in a "better" datakey.

(cherry picked from commit cf7f175)
@outscale-fba @nicolas2bert
FT: AWS KMS, fix lint errors + env var renaming after 1st code review
ebf3c51 
(cherry picked from commit db96279)
@outscale-fba @nicolas2bert
AWS KMS: TLS configuration
a51c616 
(cherry picked from commit 853102f)
@nicolas2bert
CLDSRV-559 AWS KMS backend
f071bbf 
(cherry picked from commit a63387e)
@bert-e
Copy link
Contributor

bert-e commented Nov 12, 2024

Hello nicolas2bert,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Nov 12, 2024

Incorrect fix version

The Fix Version/s in issue CLDSRV-576 contains:

  • None

Considering where you are trying to merge, I expected to find at least:

  • 7.70.21.1

Please check the Fix Version/s of CLDSRV-576, or the target
branch of this pull request.

@nicolas2bert nicolas2bert force-pushed the improvement/CLDSRV-576/aws-kms branch from 39e8f93 to 6e4e49c Compare November 12, 2024 15:23
@bert-e
Copy link
Contributor

bert-e commented Nov 12, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

anurag4DSB
anurag4DSB approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@anurag4DSB anurag4DSB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving as cherry-picked

@nicolas2bert
Copy link
Contributor Author

@bert-e approve

@bert-e
Copy link
Contributor

bert-e commented Nov 13, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ hotfix/7.70.21

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.6
  • development/8.7
  • development/8.8

Please check the status of the associated issue CLDSRV-576.

Goodbye nicolas2bert.

The following options are set: approve

@bert-e bert-e merged commit 6e4e49c into hotfix/7.70.21 Nov 13, 2024
8 checks passed
@bert-e bert-e deleted the improvement/CLDSRV-576/aws-kms branch November 13, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvasilas dvasilas dvasilas approved these changes

@anurag4DSB anurag4DSB anurag4DSB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas2bert @bert-e @anurag4DSB @dvasilas @outscale-fba