-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support bigint during quota evaluation #5729
base: development/8.8
Are you sure you want to change the base?
Conversation
Otherwise, BigInt wouldn't be properly detected as a built-in variable. Issue: CLDSRV-606
Hello williamlardier,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
2948856
to
65bb1cd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files
@@ Coverage Diff @@
## development/8.8 #5729 +/- ##
================================================
Coverage 64.46% 64.46%
================================================
Files 185 185
Lines 11638 11638
================================================
Hits 7502 7502
Misses 4136 4136
Flags with carried forward coverage won't be shown. Click here to find out more. |
6c03e66
to
afb9f7a
Compare
Java 6 is now blocked, and CI is blocked. Issue: CLDSRV-606
afb9f7a
to
711e9b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The quota backend will return the metrics as string, but the actual number may exceed the max safe integer (2^53-1), hence we risk computing wrong metrics.
This is a partial fix: the scubaclient lib must later be updated to reflect the right return type. For now we don't use types in cloudserver so not a blocker, plus, we don't have a proper version yet, and use a hash. Using the latest version will require more changes.
Note: there is no issue with both bucket and account quotas when the quota number if high, because we do not change the value, only read it.
Issue: CLDSRV-606
To be completed with quota support as BigInts