Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bigint during quota evaluation #5729

Open
wants to merge 4 commits into
base: development/8.8
Choose a base branch
from

Conversation

williamlardier
Copy link
Contributor

@williamlardier williamlardier commented Jan 15, 2025

The quota backend will return the metrics as string, but the actual number may exceed the max safe integer (2^53-1), hence we risk computing wrong metrics.

This is a partial fix: the scubaclient lib must later be updated to reflect the right return type. For now we don't use types in cloudserver so not a blocker, plus, we don't have a proper version yet, and use a hash. Using the latest version will require more changes.

Note: there is no issue with both bucket and account quotas when the quota number if high, because we do not change the value, only read it.

Issue: CLDSRV-606

To be completed with quota support as BigInts

Otherwise, BigInt wouldn't be properly detected as a built-in
variable.

Issue: CLDSRV-606
@bert-e
Copy link
Contributor

bert-e commented Jan 15, 2025

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jan 15, 2025

Incorrect fix version

The Fix Version/s in issue CLDSRV-606 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.8.41

  • 9.0.0

Please check the Fix Version/s of CLDSRV-606, or the target
branch of this pull request.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.46%. Comparing base (d6bfe84) to head (711e9b7).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/api/apiUtils/quotas/quotaUtils.js 89.81% <ø> (ø)
@@               Coverage Diff                @@
##           development/8.8    #5729   +/-   ##
================================================
  Coverage            64.46%   64.46%           
================================================
  Files                  185      185           
  Lines                11638    11638           
================================================
  Hits                  7502     7502           
  Misses                4136     4136           
Flag Coverage Δ
unit 64.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@williamlardier williamlardier force-pushed the bugfix/CLDSRV-606 branch 7 times, most recently from 6c03e66 to afb9f7a Compare January 16, 2025 15:19
Copy link
Contributor

@benzekrimaha benzekrimaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants