layered: Fix init_task #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I transitioned layered to using task local storage, I messed up initializing the task ctx, not realizing we previously had a separate variable that was initializing the hasmap entry. We need to initialize the task's layer to -11, and also set refresh_layer to 1. Signed-off-by: David Vernet <[email protected]>
Byte-Lab
force-pushed
the
layer_init_task
branch
from
2026e73
to
5f1eac8
Compare
htejun
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I transitioned layered to using task local storage, I messed up initializing the task_ctx, not realizing we had a separate object that was previously being used to initialize the hashmap entry. We need to initialize the task's layer to -1, and also set refresh_layer to 1.