Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scx: Unify loading and running boilerplate across rust schedulers #329

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

htejun
Copy link
Contributor

@htejun htejun commented Jun 3, 2024

Make restart handling with user_exit_info simpler and consistently use the load and report macros consistently across the rust schedulers. This makes all schedulers automatically handle auto restarts from CPU hotplug events. Note that this is necessary even for scx_lavd which has CPU hotplug operations as CPU hotplug operations which took place between skel open and scheduler init can still trigger restart.

Make restart handling with user_exit_info simpler and consistently use the
load and report macros consistently across the rust schedulers. This makes
all schedulers automatically handle auto restarts from CPU hotplug events.
Note that this is necessary even for scx_lavd which has CPU hotplug
operations as CPU hotplug operations which took place between skel open and
scheduler init can still trigger restart.
@htejun
Copy link
Contributor Author

htejun commented Jun 3, 2024

@arighi The commit ends up changing unrelated formatting in rlfifo. If this doesn't agree with your cargo fmt, let's come up with a way to sync that.

Copy link
Contributor

@multics69 multics69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Contributor

@arighi arighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@htejun htejun merged commit 5b49655 into main Jun 4, 2024
1 check passed
@htejun htejun deleted the htejun/cleanup-loading-and-running branch June 4, 2024 16:51
@htejun htejun restored the htejun/cleanup-loading-and-running branch June 16, 2024 06:25
@htejun htejun deleted the htejun/cleanup-loading-and-running branch June 16, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants