scx_rustland: never use a time slice that exceeds the default value #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure to never assign a time slice longer than the default time slice, that can be used as an upper limit. This seems to prevent potential stall conditions (reported by the CachyOS community) when running CPU-intensive workloads, such as: [ 68.062813] sched_ext: BPF scheduler "rustland" errored, disabling [ 68.062831] sched_ext: runnable task stall (ollama_llama_se[3312] failed to run for 5.180s) [ 68.062832] scx_watchdog_workfn+0x154/0x1e0 [ 68.062837] process_one_work+0x18e/0x350 [ 68.062839] worker_thread+0x2fa/0x490 [ 68.062841] kthread+0xd2/0x100 [ 68.062842] ret_from_fork+0x34/0x50 [ 68.062844] ret_from_fork_asm+0x1a/0x30 Fixes: 6f4cd85 ("scx_rustland: introduce virtual time slice") Tested-by: SoulHarsh007 <[email protected]> Tested-by: Piotr Gorski <[email protected]> Signed-off-by: Andrea Righi <[email protected]>
sirlucjan
approved these changes
Jun 6, 2024
htejun
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to never assign a time slice longer than the default time slice, that can be used as an upper limit.
This seems to prevent potential stall conditions (reported by the CachyOS community) when running CPU-intensive workloads, such as:
[ 68.062813] sched_ext: BPF scheduler "rustland" errored, disabling
[ 68.062831] sched_ext: runnable task stall (ollama_llama_se[3312] failed to run for 5.180s)
[ 68.062832] scx_watchdog_workfn+0x154/0x1e0
[ 68.062837] process_one_work+0x18e/0x350
[ 68.062839] worker_thread+0x2fa/0x490
[ 68.062841] kthread+0xd2/0x100
[ 68.062842] ret_from_fork+0x34/0x50
[ 68.062844] ret_from_fork_asm+0x1a/0x30
Fixes: 6f4cd85 ("scx_rustland: introduce virtual time slice")
Tested-by: SoulHarsh007 [email protected]
Tested-by: Piotr Gorski [email protected]