Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "scx_rusty: Refactor ridx assignment in populate_tasks_by_load" #393

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

Byte-Lab
Copy link
Contributor

Reverts #382

Causes the following issue:

21:32:36 [INFO] Running scx_rusty (build ID: 0.8.1-g41d60aef04d2a7fc0da738bf50391ea5f232ddd3 x86_64-unknown-linux-gnu/debug)                                
21:32:36 [INFO] ---                                                           
21:32:36 [INFO] NUMA[00] mask= 0b11111111111111111111111111111111             
21:32:36 [INFO]   DOM[00] mask= 0b00000000111111110000000011111111            
21:32:36 [INFO]   DOM[01] mask= 0b11111111000000001111111100000000            
21:32:36 [INFO] Rusty scheduler started!                                                                                                                    
thread 'main' panicked at src/load_balance.rs:689:25:
attempt to subtract with overflow
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

We can instead add a comment explaining the weird logic, or figure out another way to do it.

@Byte-Lab Byte-Lab merged commit 8537c1b into main Jun 26, 2024
1 check passed
@Byte-Lab Byte-Lab deleted the revert-382-rusty_refactor branch June 26, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant